Skip to content

Add codeQL.model.packName setting#3543

Merged
koesie10 merged 2 commits intomainfrom
koesie10/pack-name-config
Apr 10, 2024
Merged

Add codeQL.model.packName setting#3543
koesie10 merged 2 commits intomainfrom
koesie10/pack-name-config

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Apr 8, 2024

This adds the codeQL.model.packName setting, which allows users to specify the name of the CodeQL model pack. Like the codeQL.model.packLocation setting added in #3539, this supports variable substitutions. After the variable substitution has been performed, we'll try to "sanitize" the name to make it valid. The default value is ${owner}/${name}-${language} which matches the previous behavior.

My plan is to add the CHANGELOG entry when all three settings have been added, rather than for each one individually.

Screenshot 2024-04-08 at 13 55 35

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Base automatically changed from koesie10/pack-location-config to main April 8, 2024 12:11
@koesie10 koesie10 force-pushed the koesie10/pack-name-config branch from b1b0ae3 to bf9bfb1 Compare April 8, 2024 12:42
@koesie10 koesie10 marked this pull request as ready for review April 8, 2024 13:11
@koesie10 koesie10 requested review from a team as code owners April 8, 2024 13:11
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@koesie10 koesie10 merged commit 8c784d8 into main Apr 10, 2024
@koesie10 koesie10 deleted the koesie10/pack-name-config branch April 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants